Skip to content

Bug 2006684 - add builddecisionscript#1412

Open
jcristau wants to merge 8 commits into
mozilla-releng:masterfrom
jcristau:builddecisionscript
Open

Bug 2006684 - add builddecisionscript#1412
jcristau wants to merge 8 commits into
mozilla-releng:masterfrom
jcristau:builddecisionscript

Conversation

@jcristau
Copy link
Copy Markdown
Contributor

@jcristau jcristau commented Mar 26, 2026

Port the build-decision code to run as a scriptworker task.

The following changes have been made:

  • use taskgraph.util.keyed_by instead of a local copy
  • input is taken from fields in the task payload instead of either command-line arguments or the environment
  • we don't have a taskcluster proxy; instead we use temporary credentials obtained/maintained by scriptworker to create tasks / trigger hooks / fetch secrets
  • the CLI is modified to match other scriptworkers

Unlike other scriptworkers, we skip chain of trust verification.

@jcristau jcristau force-pushed the builddecisionscript branch 3 times, most recently from cd74711 to 3e75319 Compare March 26, 2026 18:06
@jcristau jcristau changed the title Add builddecisionscript Bug 2006684 - add builddecisionscript May 19, 2026
@jcristau jcristau force-pushed the builddecisionscript branch from a5a19fb to cbecacb Compare May 19, 2026 15:07
jcristau added 5 commits May 22, 2026 10:14
Copy the build-decision code from fxci-config as-is, at revision
6b1ea576b59f8436b28778d5ef2bdd09c80ec348, before adapting it to run
as a scriptworker task.
Port the build-decision code to run as a scriptworker task.

- rename the project from build-decision to builddecisionscript
- adapt the original env-var and cmdline based input to be passed
  through the scriptworker task payload instead
- add the usual scriptworker boilerplate
We'll have a single worker pool here so override the default
scriptworker worker type/group/id.
We can use taskgraph directly, no need to keep a copy of these
functions.
@jcristau jcristau force-pushed the builddecisionscript branch from 47b9491 to 25f35d3 Compare May 26, 2026 09:40
@jcristau jcristau marked this pull request as ready for review May 26, 2026 09:41
@jcristau jcristau requested a review from a team as a code owner May 26, 2026 09:41
@jcristau
Copy link
Copy Markdown
Contributor Author

This depends on mozilla-releng/scriptworker#798 to get temporary tc credentials with the task's scopes.

jcristau added 3 commits May 26, 2026 13:24
… (bug 2006684)

There's no proxy in scriptworker, we talk to tc directly.  Use the
credentials fd passed by scriptworker for all taskcluster operations
(fetching secrets, triggering hooks, creating tasks).
@jcristau jcristau force-pushed the builddecisionscript branch from 016d35f to d35e8a4 Compare May 26, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant